On Tue, 13 Feb 2007, Guilherme Salgado wrote: > Hi Alan,
> > Below is a revised version of the diagnostic patch. Try using it instead > > of the earlier one and let's see what happens. > > > > This revised version didn't apply cleanly into my tree, Maybe because you didn't remove the original patch first? > so I did the > changes manually and used upper case characters on the message passed > to dev_info(), to make sure the new module was loaded correctly, and I > seem to have got the same thing on syslog: There were only two differences between the patch you typed in and the one I sent. One difference was the capital letters in the log message. The other difference is here: > > + if (!(inw(port_addr) & > > + (USBPORTSC_SUSP | USBPORTSC_RD))) > + if (!(inw(port_addr) & > + (USBPORTSC_RD | USBPORTSC_RD))) You typed USBPORTSC_RD twice instead of USBPORTSC_SUSP. Unfortunately, that was the whole point of the new patch. So the patch you tested was essentially the same as the original one. Alan Stern ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
