On Monday 19 March 2007 1:29 pm, Ragner Magalhaes wrote: > The following patch implements USB Video Class 1.1 as defined at > USB Device Class Definition for Video Devices, available at:
No it doesn't ... it declares on-the-wire *structures* passed. There's not one line of implementation code there ... either host side, or peripheral side. So at least, the comment is wrong. :) This needs some review against the spec. I know that several folk have been looking at providing implementations, so I'm glad to see the common struct declarations, but I'd like to see feedback from people who've started such coding... and code sharing, e.g. with the Berlios stuff. USB_CC_VIDEO doesn't belong in this file; <linux/usb/ch9.h> already defines USB_CLASS_VIDEO anyway. Likewise with USB_CS_* and ch9.h USB_DT_CS_* symbols ... I see a lot of *_UNDEFINED symbols, which seem dubious. If it's not defined, then it shouldn't be defined! Wouldn't want to see anyone assume that if a value doesn't match those *_UNDEFINED symbols, it must accordingly be defined, for example. - Dave ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
