On Wed, Mar 21, 2007 at 03:41:26PM -0500, Curran, Dominic wrote: > > > > > > > > > > I don't see much use for adding this information if it's not even > > going > > > > to be included by any file just yet :( > > > I published this patch now for that somebody can help me later. > > > > Ok, but the structures were the easy part :) > > > > I'll wait to add this to the tree when there is some code using it. > > > > Greg, I thought that the preferred model for submitting a new driver was > to provide it in small bits, and not as one bit chunk at the end. > > Doesn't a header file qualify as a small bit ?
It does, yes, but you need to then have code that uses it, otherwise the kernel janitors will come along and delete the thing :) > I've always been a bit confused by what in practice you do want from new > drivers, so I'm very interested in what you are expecting. In this case, provide a series of patches, each building on each other in a sequence. So, the first patch might be this header file, and the second the driver itself. Generally for individual drivers, of moderate size, it can all be in one single patch. thanks, greg k-h ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel