Hi Pete,
On 3/30/07, Pete Zaitcev <[EMAIL PROTECTED]> wrote:
>
> I didn't like a) layering violation, and b) that they defeat filtering
> unconditionally. Why have any filtering then?
>
> Instead, I propose for USB HID driver to reset NumLock on probe. Like this:
>
> --- a/drivers/usb/input/hid-core.c
> +++ b/drivers/usb/input/hid-core.c
> @@ -458,6 +458,18 @@ static int usb_hidinput_input_event(struct input_dev
> *dev, unsigned int type, un
> return 0;
> }
>
> +static void usbhid_set_leds(struct hid_device *hid, unsigned int code, int
> val)
> +{
> + struct hid_field *field;
> + int offset;
> +
> + /* This is often called for the mouse half. */
> + if ((offset = hidinput_find_field(hid, EV_LED, code, &field)) != -1) {
> + hid_set_field(field, offset, val);
> + usbhid_submit_report(hid, field->report, USB_DIR_OUT);
> + }
> +}
> +
This is fine and that's what we do in atkbd probe but maybe we should
move that in input core and reset leds as part of
input_register_device()?
--
Dmitry
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
