On Sat, 19 May 2007, Sam Liddicott wrote: > > Do you actually own the hardware? I would appreciate if you could test > > whether really both of the quirks are needed - we don't want to add > > unneeded quirks to devices, that would just spread confusion. > OK. I'm not sure how to tell if the poll quirk is needed or not. > Any tips?
Hi Sam, well there are basically two main things that could happen if the device needs HID_QUIRK_NOGET and we don't set it in hid_blacklist[] - either it could timeout for ~10 seconds during initialization (as it would just drop the Get request), or it could respond with bogus values to Get request, and therefore the subsequent data processing would return bogus values. The common symptom for both cases is - the device just won't work as expected :) > > =Also, could you please resend the patch with proper > > =Signed-off-by line? > Oh yes, sorry. And also proper Changelog please (i.e. "this device has that many input interfaces and so it needs HID_QUIRK_MULTI_INPUT and it acts so and so and therefore needs HID_QUIRK_NOGET). Thanks, -- Jiri Kosina SUSE Labs ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
