Am Donnerstag, 17. Mai 2007 20:39 schrieb Pete Zaitcev:
> I think we should remove those local_irq_save's, and leave just the
> guarantee that it won't be re-entered (currently such a guarantee
> is inherited from the Linux's interrupt handling, and we'll only
> need to make it explicit if any HCDs start using softirq when
> calling the giveback routine). I'm poking your memory in case
> there's actually a good reason for it which I forgot.
If you do this
1. all drivers need to be audited for simple 'spin_lock()'
2. Doing so will make the common code path needlessly slower
3. If any HCD calls the callback from interrupt, you'll need to take
a lock and disable interrupts anyway
Regards
Oliver
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
