On Wed, 23 May 2007, Oliver Neukum wrote:

> OK, these are fixed and the timeout given in milliseconds, as David
> recommended.
> 
> I looked into the inlining issue and the inlined version wins in terms
> of size.


> @@ -1270,6 +1287,11 @@ extern struct urb *usb_get_urb(struct ur
>  extern int usb_submit_urb(struct urb *urb, gfp_t mem_flags);
>  extern int usb_unlink_urb(struct urb *urb);
>  extern void usb_kill_urb(struct urb *urb);
> +extern void usb_kill_anchored_urbs(struct usb_anchor *anchor);
> +extern void usb_anchor_urb(struct urb *urb, struct usb_anchor *anchor);
> +extern void usb_unanchor_urb(struct urb *urb);
> +extern int usb_wait_anchor_empty_timeout
> +(struct usb_anchor *anchor, unsigned long timeout);

Suspicious line break.

> +int usb_wait_anchor_empty_timeout(struct usb_anchor *anchor, unsigned long 
> timeout)
> +{
> +     int res;
> +
> +     res = wait_event_timeout(anchor->wait, list_empty(&anchor->urb_list), 
> timeout * HZ / 1000);

What's wrong with msecs_to_jiffies()?

Ironically, it wants its argument to be an unsigned int!

Alan Stern


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to