On Tue, 29 May 2007 10:14:35 -0500 <[EMAIL PROTECTED]> wrote: > > Sorry about that. Would it be helpful if I verified that and sent it in > signed off? >
Yes please. The question in my mind was "did it add a race": say, the notifier chain gets called by some external source after we've gone and reset the device? > > -----Original Message----- > From: Andrew Morton [mailto:[EMAIL PROTECTED] > Sent: Friday, May 25, 2007 5:00 PM > To: Greg KH > Cc: Mattia Dongili; Linux Kernel Mailing List; Hayes, Stuart; David > Brownell; linux-usb-devel@lists.sourceforge.net > Subject: Re: [2.6.22-rc1-mm1] ehci-hcd - BUG: scheduling while atomic: > rmmod/0x00000001/4568 > > On Fri, 25 May 2007 14:40:05 -0700 Greg KH <[EMAIL PROTECTED]> wrote: > > > On Mon, May 21, 2007 at 11:44:37AM +0900, Mattia Dongili wrote: > > > Hello, > > > > > > with gregkh-usb-usb-ehci-cpufreq-fix.patch removing ehci-hcd causes > > > the following BUG: > > > > Thanks for letting me know. > > > > Stuart, any help here? > > pretty obvious. cpufreq_unregister_notifier() sleeps, and that patch > causes it to be called under spinlock. > > Something like this... > > --- a/drivers/usb/host/ehci-hcd.c~fix-gregkh-usb-usb-ehci-cpufreq-fix > +++ a/drivers/usb/host/ehci-hcd.c > @@ -452,14 +452,14 @@ static void ehci_stop (struct usb_hcd *h > if (HC_IS_RUNNING (hcd->state)) > ehci_quiesce (ehci); > > -#ifdef CONFIG_CPU_FREQ > - cpufreq_unregister_notifier(&ehci->cpufreq_transition, > - CPUFREQ_TRANSITION_NOTIFIER); > -#endif > ehci_reset (ehci); > ehci_writel(ehci, 0, &ehci->regs->intr_enable); > spin_unlock_irq(&ehci->lock); > > +#ifdef CONFIG_CPU_FREQ > + cpufreq_unregister_notifier(&ehci->cpufreq_transition, > + CPUFREQ_TRANSITION_NOTIFIER); > +#endif > /* let companion controllers work when we aren't */ > ehci_writel(ehci, 0, &ehci->regs->configured_flag); > > _ ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
