Here's the patch.

        Bruno

Le lun 15/11/2004 à 19:49, A.P.Munnikes a écrit :
> hello,
> 
> Could you post a patch ?
> 
> 
> Alfred
> 
> 
>   Thank you Alan.
> 
>   I have modified the uhci driver to accept
>   the buggy configuration. And now the printer works...
> 
>       Bruno
> 
>   Le lun 08/11/2004 à 19:01, Alan Stern a écrit :
>   > On Mon, 8 Nov 2004, Bruno Zoppis wrote:
>   >
>   > > Hi,
>   > >
>   > > Anybody knows why it should not be possible
>   > > to have an endpoint in bulk mode for a low speed
>   > > device ? The uhci_submit_bulk function in
>   > > uhci-hcd.c returns -EINVAL in that case.
>   > >
>   > > But according to /proc/bus/usb/devices, the
>   > > device I"m trying to use (DYMO LabelWriter 320)
>   > > is a low speed one with bulk endpoints.
>   >
>   > It"s not possible because the USB specification says that low-speed
>   > devices are only allowed to support control and interrupt endpoints.
>   > Apparently your device contains an illegal configuration.
>   >
>   > Alan Stern
>   >
> 
diff -ru linux-2.6.9/drivers/usb/host/uhci-hcd.c linux-2.6.9-labelwriter/drivers/usb/host/uhci-hcd.c
--- linux-2.6.9/drivers/usb/host/uhci-hcd.c	2004-10-18 23:55:07.000000000 +0200
+++ linux-2.6.9-labelwriter/drivers/usb/host/uhci-hcd.c	2004-11-16 22:01:28.090576768 +0100
@@ -1150,8 +1150,9 @@
 	int ret;
 
 	/* Can't have low-speed bulk transfers */
-	if (urb->dev->speed == USB_SPEED_LOW)
-		return -EINVAL;
+	/* if (urb->dev->speed == USB_SPEED_LOW)
+	 *	return -EINVAL;
+	*/
 
 	ret = uhci_submit_common(uhci, urb, eurb, uhci->skel_bulk_qh);
 	if (ret == -EINPROGRESS)

Reply via email to