Hi!
Myself, I'd prefer to specify the speed as a value in megabits, ie
"12Mbit" for the "Full speed" mode. This way noone gets ever confused
about which speed is "Full" and which is "High". What does everyone
think?
Vojtech
On Mon, May 15, 2000 at 10:27:54PM -0700, Adam J. Richter wrote:
> The USB 2.0 specification uses the term "High Speed" to
> refer to 480Mb/s and "Full Speed" to refer to 12Mb/sec (the fastest
> speed available in USB 1.0 and 1.1). I believe that the status messages
> are referring to USB 1.x speeds, and therefore should use the term
> "Full Speed" rather than "High Speed". The following trivial patch
> makes that change.
>
> Adam J. Richter __ ______________ 4880 Stevens Creek Blvd, Suite 104
> [EMAIL PROTECTED] \ / San Jose, California 95129-1034
> +1 408 261-6630 | g g d r a s i l United States of America
> fax +1 408 261-6631 "Free Software For The Rest Of Us."
> -------------------------CUT HERE--------------------------------------
>
> --- linux-2.3.99-pre9-2/drivers/usb/hub.c Mon May 15 22:18:49 2000
> +++ linux/drivers/usb/hub.c Mon May 15 22:17:35 2000
> @@ -338,7 +338,7 @@
> portstatus = le16_to_cpu(portsts.wPortStatus);
> portchange = le16_to_cpu(portsts.wPortChange);
> dbg("portstatus %x, change %x, %s", portstatus, portchange,
> - portstatus&(1<<USB_PORT_FEAT_LOWSPEED) ? "Low Speed" : "High Speed");
> + portstatus&(1<<USB_PORT_FEAT_LOWSPEED) ? "Low Speed" : "Full Speed");
>
> /* Clear the connection change status */
> usb_clear_port_feature(hub, port + 1, USB_PORT_FEAT_C_CONNECTION);
> @@ -369,7 +369,7 @@
> portstatus = le16_to_cpu(portsts.wPortStatus);
> portchange = le16_to_cpu(portsts.wPortChange);
> dbg("portstatus %x, change %x, %s", portstatus ,portchange,
> - portstatus&(1<<USB_PORT_FEAT_LOWSPEED) ? "Low Speed" : "High
>Speed");
> + portstatus&(1<<USB_PORT_FEAT_LOWSPEED) ? "Low Speed" : "Full
>Speed");
>
> if ((portchange & USB_PORT_STAT_C_CONNECTION) ||
> !(portstatus & USB_PORT_STAT_CONNECTION))
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
--
Vojtech Pavlik
SuSE Labs
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
