On Sun, Aug 13, 2000 at 11:23:31PM +0100, Russell King wrote:
> Vojtech Pavlik writes:
> > On Sun, Aug 13, 2000 at 10:56:56PM +0100, Alan Cox wrote:
> > > > > -OX_OBJS              := $(sort $(filter     $(export-objs), $(obj-y)))
> > > > > +O_OBJS               := $(filter-out $(export-objs), $(obj-y))
> > > > > +OX_OBJS              := $(filter     $(export-objs), $(obj-y))
> > > > 
> > > > I fear that this change will make some modules linked in more than once.
> > > > the $sort was put there for exactly that reason.
> > > 
> > > Sort is not the correct solution to that anyway - it breaks the ordering.
> > 
> > True. Ordering should not be important for USB, though. Any better solution?
> 
> Ok, there is a fix for this type of problem that was mentioned on lkml last week.
> See http://www.uwsg.indiana.edu/hypermail/linux/kernel/0008.0/0223.html for the
> mail.
> 
> Here is a new patch using this scheme:

Yes, this looks good.

-- 
Vojtech Pavlik
SuSE Labs

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to