On Sun, Jan 27, 2008 at 07:07:48AM -0600, Felipe Balbi wrote:
> 
> 
> On Sat, 26 Jan 2008 20:59:44 -0800, Greg KH <[EMAIL PROTECTED]> wrote:
> > On Sat, Jan 26, 2008 at 08:40:48PM -0600, Felipe Balbi wrote:
> >>
> >>
> >> On Fri, 25 Jan 2008 08:56:35 -0800, Greg KH <[EMAIL PROTECTED]> wrote:
> >> > Hi all,
> >> >
> >> > I have a report here of a device in the wild that is using a USB
> > vendor
> >> > id of 0x0000.  From everything I can tell, this _could_ be a valid
> >> > vendor id, but I'm pretty sure that it isn't :)
> >>
> >> Why would usb-if give someone the Vendor ID of 0 ?
> >> This can't be valid.
> > 
> > I know, it looks like it would be invalid, but you have a shipping
> > device with it, and I can't see anything in the USB documentation that
> > forbids it :(
> 
> FYI, If you know the company name, you can at least search for it in
> usb.org.
> 
> Log in to members area and go to Member search.

Yes, but it does not show the vendor id for the company.  Or am I
missing something on that page somewhere?

> >> > Here's the bug report, does anyone have an idea of what we should do
> >> > here?
> >> >
> >> > At first glance, we should probably fix the scripts/mod/file2alias.c
> >> > code that does the following in do_usb_entry_multi():
> >> >
> >> >         /*
> >> >          * Some modules (visor) have empty slots as placeholder for
> >> >          * run-time specification that results in catch-all alias
> >> >          */
> >> >         if (!(id->idVendor | id->bDeviceClass | id->bInterfaceClass))
> >> >                 return;
> >> >
> >> > And check both that idVendor and idProduct are 0x0000 before falling
> > out.
> >> >
> >> > Does anyone see a problem with that?
> >>
> >> sounds, but the linux foundation vendor id will be better :-)
> > 
> > Well, that will fix the root hub issue, but this device still needs to
> > work properly.  It does on Windows :)
> 
> What I meant was if Linux' Root hub is not 0x000 anymore, you could remove
> the
> !id->idVendor. Couldn't you ?

No, read the comment there :)

We need to check for both idVendor and idProduct being 0, as some
modules use a "blank" line for adding new device ids dynamically.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to