On Mon, 11 Feb 2008, Randy Dunlap wrote:
> On Sun, 10 Feb 2008 20:23:14 -0600 (CST) Mike Isely wrote:
>
> >
> > cypress_m8: Feature buffer fixes
> >
> > From: Mike Isely <[EMAIL PROTECTED]>
> >
> > Don't hardcode the feature buffer size; use sizeof() instead. That
> > way we can easily specify the size in a single spot. Speaking of the
> > feature buffer size, the Cypress app note (and further testing with a
> > DeLorme Earthmate) suggests that this size should be 5 not 8 bytes.
> >
> > Signed-off-by: Mike Isely <[EMAIL PROTECTED]>
> >
> > ---
> > cypress_m8.c | 18 +++++++++---------
> > 1 file changed, 9 insertions(+), 9 deletions(-)
>
> Hi,
> Please use "diffstat -p1 -w70" as written in Documentation/SubmittingPatches,
> so that readers can see the full path of modified files.
OK, I will ensure that in the future, but...
The reader can't see the path in the patch itself?
I had included the diffstat piece as a convenience. Obviously the patch
itself which includes the full path is the critical part. And the last
time I submitted patches for this driver about a year and a half ago,
this wasn't an issue. The patches themselves are not that large and all
affect only a single source file: drivers/usb/serial/cypress_m8.c.
Am I going to have to now resubmit these because of this?
-Mike
--
| Mike Isely | PGP fingerprint
Spammers Die!! | | 03 54 43 4D 75 E5 CC 92
| isely @ pobox (dot) com | 71 16 01 E2 B5 F5 C1 E8
| |
-
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
