On Tue, 19 Feb 2008, Greg KH wrote: > On Sun, Feb 10, 2008 at 08:23:14PM -0600, Mike Isely wrote: > > > > cypress_m8: Feature buffer fixes > > > > From: Mike Isely <[EMAIL PROTECTED]> > > > > Don't hardcode the feature buffer size; use sizeof() instead. That > > way we can easily specify the size in a single spot. Speaking of the > > feature buffer size, the Cypress app note (and further testing with a > > DeLorme Earthmate) suggests that this size should be 5 not 8 bytes. > > > > Signed-off-by: Mike Isely <[EMAIL PROTECTED]> > > Next time can you please run scripts/checkpatch.pl on your patches and > fix up any errors or warnings found there before sending them on to me? > > Don't worry, I've fixed them up this time. > > thanks, >
Greg: A couple quick notes. First, you're right I should have run that checker. I just now did that to see what the issues were and they were primarily things that got carried across from code that was already there (but got flagged now because it was swept up into the diff as part of a cut/paste or similar thing). The 80 column errors were an indirect effect. So much of the source file violates that "strong suggestion" that I had expanded my editor width to cope with it and thus I missed all the cases where I had accidentally introduced additional violations of this type. But obviously I would have caught this had I run the script. It might be a useful exercise to sweep through the entire driver and clean up all outstanding issues like this. The driver isn't that large so it should be doable without too much pain. Would you be interested in a patch for this? I also note that the official cypress_m8 maintainer didn't respond to or sign-off my patches (yet) so I don't know what his status is with respect to this driver. -Mike -- Mike Isely isely @ pobox (dot) com PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8 - To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
