Hi Felipe
Thank you for checking this patch
> > +/* USBH common register */
> > +#define USBPCTRL0 0x0800
> > +#define USBPCTRL1 0x0804
> > +#define USBST 0x0808
> > +#define USBEH0 0x080C
> > +#define USBOH0 0x081C
> > +#define USBCTL0 0x0858
> > +#define EIIBC1 0x0094
> > +#define EIIBC2 0x009C
(snip)
> > + reg0 = devm_ioremap_nocache(dev, res0->start, resource_size(res0));
> > + reg1 = devm_ioremap_nocache(dev, res1->start, resource_size(res1));
>
> please use devm_request_and_ioremap().
Sorry about this, but I would like to keep devm_ioremap_nocache() here,
because this Renesas R-Car PHY address has strange mapping.
Some registers of this PHY address are mapped to crevice of USB EHCI/OHCI
register area.
like this
0xAAAA0000 ===========
EHCI
----------
0xAAAA0094 PHY
0xAAAA009C PHY
----------
EHCI
0xAAAA0400 ==========
...
0xAAAA0800 ----------
PHY
0xAAAA0900 ----------
This driver couldn't probe if it used "request_mem_region()"
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
