On Mi, 2018-06-13 at 22:28 +0200, Sebastian Andrzej Siewior wrote:
> On 2018-06-13 19:43:55 [+0200], Oliver Neukum wrote:
> >
>
> Hi Oliver,
Hi Sebastian,
> > I am just looking at your patch and I am wondering why
> > wdm_in_callback() won't just call service_outstanding_interrupt()
> > again and again? OK, maybe I am dense and it may well be present now,
> > but it just looks to me that way.
>
> But this part didn't change, did it?
Right, it didn't change, but that does not make it correct.
> The user blocks in wdmw_read()
We can only hope that he does. The wait is interruptible.
If a signal comes at the wrong time, nobody will be waiting.
> Maybe we should delay the WDM_READ flag in the error case until the
> worker is done (before the wakeup).
I don't think that will help. It seems like we need to make sure
that error recovery is a one shot activity.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
