Hi, >> Roger Quadros <[email protected]> writes: >> >> +static void cdns3_gadget_config(struct cdns3_device *priv_dev) { >> >> + struct cdns3_usb_regs __iomem *regs = priv_dev->regs; >> >> + >> >> + cdns3_ep0_config(priv_dev); >> >> + >> >> + /* enable interrupts for endpoint 0 (in and out) */ >> >> + writel(EP_IEN_EP_OUT0 | EP_IEN_EP_IN0, ®s->ep_ien); >> >> + >> >> + /* enable generic interrupt*/ >> >> + writel(USB_IEN_INIT, ®s->usb_ien); >> >> + writel(USB_CONF_CLK2OFFDS | USB_CONF_L1DS, ®s->usb_conf); >> >> + writel(USB_CONF_DMULT, ®s->usb_conf); >> >> + writel(USB_CONF_DEVEN, ®s->usb_conf); >> > >> > If you are enabling interrupts in this patch you should handle them in the >> > ISR. >> >> Frankly, I don't understand why this is a series. It's a single driver and >> splitting it into >> a series just makes it more difficult to review, actually. >> >> Sure, a single patch will be large, but there's no way to have a functional >> driver until >> all patches are applied, anyway. >> > >Yes, I agree with Felipe. Pawel, you could remove the "RFC" prefix, and send >the whole >one as one patch. I will test it at my hardware.
Ok, I will prepare such single patch. Peter I know that you have little different platform. Probably you should made some additional changes for your platform. I assume that core.c should be common file. Probably we should add also some platform specific file. Thanks. Pawel.
