On Wed, Jul 24, 2013 at 01:02:31PM -0400, Alan Stern wrote:
> On Wed, 24 Jul 2013, Sarah Sharp wrote:
>
> > > > +#ifdef CONFIG_PM
> > > > +static int xhci_plat_suspend(struct device *dev)
> > > > +{
> > > > + struct usb_hcd *hcd = dev_get_drvdata(dev);
> > > > + struct xhci_hcd *xhci = hcd_to_xhci(hcd);
> > > > +
> > > > + return xhci_suspend(xhci);
> > > > +}
> > >
> > > Where does the wakeup setting get taken into account?
> >
> > Which wakeup setting are you talking about? Do you mean making sure the
> > wake on bits are set for the roothub ports when the bus is suspended?
> > Or do you mean that the platform device needs to have some way to enable
> > wake from S3/S4 for the xHCI host controller itself?
>
> The latter. Not only does there need to be some mechanism to wake up
> the system from S3/S4 when the xHCI controller detects a wakeup event;
> there also has to be a way to enable or disable this mechanism
> depending on the value of device_may_wakeup(dev).
Ok, that sounds like something that needs to be addressed on top of this
patch. Vikas, Abhilash, or Felipe, can you create a patch that fixes
this?
Thanks,
Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
