On 09/02/2013 05:58 PM, Pavel Machek wrote:
> Hi!
>
> checkpatch.pl has some valid complaints about style in s3c-hsotg.c :
> macro with if should be really enclosed in do {} while, and puts is
> going to be slightly faster.
>
> Here's suggested patch. I don't have the hardware, so it is completely
> untested.CC'ed [email protected], Kukjin Kim Hi Pavel Machek, I have the hardware. :-) Also, I am developing USB stuff of Samsung SoCs. > > Signed-off-by: Pavel Machek, <[email protected]> > > diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c > index af22f24..f8e762a 100644 > --- a/drivers/usb/gadget/s3c-hsotg.c > +++ b/drivers/usb/gadget/s3c-hsotg.c > @@ -2091,12 +2091,14 @@ static void kill_all_requests(struct s3c_hsotg *hsotg, > } > > #define call_gadget(_hs, _entry) \ > +do { \ > if ((_hs)->gadget.speed != USB_SPEED_UNKNOWN && \ > (_hs)->driver && (_hs)->driver->_entry) { \ > spin_unlock(&_hs->lock); \ > (_hs)->driver->_entry(&(_hs)->gadget); \ > spin_lock(&_hs->lock); \ > } > +} while (0) It makes build error. Thus, it should be fixed as below: } \ } while(0) Other things look good. Thank you for sending the patch. :) Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
