On Wed, Sep 24, 2014 at 09:41:12PM +0200, Robert Jarzmik wrote: > For this preparation, a preliminary cleanup is done : > - convert the probing of pxa27x_udc to gpio_desc. > The conversion is partial because : > - the platform data still provides a gpio number, not a gpio desc > - the "invert" attribute is lost, hence a loss in the translation
I asked for gpio to gpiod conversion to be a separate patch. It'll make things a lot easier to review. > - convert the mach info, and store the udc_command in the pxa_udc > control structure > - loose the udc_is_connected() in mach info > This was not really used, as mioa701 machine doesn't need it, > balloon3 doesn't really use it, and most importantly the current > driver never uses it. > > The drawback with the gpio_desc conversion is that the "inverted" gpio > attribute is lost, as no gpiod_*() function exists to set the it's not lost, it's handled for you by the gpio library. Look at how GPIO_ACTIVE_LOW is used. -- balbi
signature.asc
Description: Digital signature
