Hi Mathias, > From: Mathias Nyman, Sent: Wednesday, January 31, 2018 9:25 PM > > On 30.01.2018 17:54, Alan Stern wrote: > > On Tue, 30 Jan 2018, Mathias Nyman wrote: > > <snip> > >>> Question 2: > >>> - How do I resolve the issue? (I don't have any idea for now...) > >> > >> Is there any other issue than the error messags? > >> > >> we could read the portstatus in hub_port_disable() and only set the port > >> link state > >> to U3 if the port is in currently in a suitable (U0) state. > >> > >> Or then just make sure xhci_hub_control() doesn't print out any warning > >> when setting > >> link state to U3 when PORT_PE is not set, and silence hub_port_disable() > >> messages as well. > > > > I like the second idea. If xhci_hub_control() returned -ENODEV when > > asked to set the USB_PORT_FEAT_LINK_STATE feature to U3 and PORT_PE > > was clear, then hub_port_disable() wouldn't complain. > > > > Sounds like a plan, I'll submit it after rc1 > > https://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git/commit/?h=for-usb-linus&id=4b42a60487f891d03268af668 > 23a16c31c53801d
Thank you very much for the patch. I tested this branch on my environment (R-Car H3) and worked correctly. So, Tested-by: Yoshihiro Shimoda <[email protected]> Best regards, Yoshihiro Shimoda > -Mathias
