Hi Sven,

On Thursday 22 October 2009 12:13:55 Sven Geggus wrote:
> Hello,
> 
> starting from recent Kernels my ViMicro Webcam stopped working correctly im
> mjpeg mode.
> 
> Looking at the driver sources I came across the UVC_QUIRK_FIX_BANDWIDTH
> which has been activated for this camera:
> 
> Bus 002 Device 005: ID 0ac8:3420 Z-Star Microelectronics Corp.
> 
> Unfortunately this sems to do more harm than good. I made mjpeg mode work
> fine again by removing the quirks altogether (see attached patch).

Could you please try the following patch ? It disables the quirk for
compressed formats.

diff -r e0354cf2734b linux/drivers/media/video/uvc/uvc_video.c
--- a/linux/drivers/media/video/uvc/uvc_video.c Wed Oct 21 23:36:18 2009 +0200
+++ b/linux/drivers/media/video/uvc/uvc_video.c Wed Oct 28 13:42:24 2009 +0100
@@ -90,7 +90,8 @@
                ctrl->dwMaxVideoFrameSize =
                        frame->dwMaxVideoFrameBufferSize;
 
-       if (stream->dev->quirks & UVC_QUIRK_FIX_BANDWIDTH &&
+       if (!(format->flags & UVC_FMT_FLAG_COMPRESSED) &&
+           stream->dev->quirks & UVC_QUIRK_FIX_BANDWIDTH &&
            stream->intf->num_altsetting > 1) {
                u32 interval;
                u32 bandwidth;

-- 
Regards,

Laurent Pinchart
_______________________________________________
Linux-uvc-devel mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/linux-uvc-devel

Reply via email to