Hi Rogier, On Thursday 05 November 2009 11:29:36 Rogier Wolff wrote: > On Wed, Nov 04, 2009 at 03:12:07PM +0100, Laurent Pinchart wrote: > > > BTW wouldn't it be better to make the quirks module parameter > > > _overwrite_ camera specific quirks altogether instead of adding them > > > with xor? This way I would have been able to disable the quirks without > > > patching the module. > > > > It could be useful, but quirks activated by mistake (or not doing their > > job properly) shouldn't occur often as those problems result of a driver > > bug. I don't think there's really a need for this. > > On the other hand, it is very easy to allow the user to override the > default in the driver. If the driver DOES have a mistake, allowing > people who cannot recompile kernel modules to debug the problem by > executing commands like > > rmmod <module> > modprobe <module> quirks=.... > > is much easier than when you have to go through a cycle of how to get > the source code, edit the source code, and then compile a new kernel > module, and then test THAT new module, and not the one in their > distribution....
You have a point. My concern is that it could break systems with multiple UVC devices requiring different quirks, but as setting quirks= is (or at least should) be for testing only this isn't really an issue. I'll prepare and submit a patch. -- Regards, Laurent Pinchart _______________________________________________ Linux-uvc-devel mailing list [email protected] https://lists.berlios.de/mailman/listinfo/linux-uvc-devel
