On Mon, 2015-01-12 at 16:18 -0500, John W. Linville wrote:
> Add a comment indicating that the WLAN_CIPHER_SUITE_WEP104 case falls
> through to the WLAN_CIPHER_SUITE_WEP40 case in iwl_mvm_send_sta_key.
> This will document that the lack of a break is intentional.
> 
> Coverity: CID 1260023
> 
> Signed-off-by: John W. Linville <linvi...@tuxdriver.com>
> ---
> This seems to work, so I'm guessing that the fall-through is
> intentional...
> 
>  drivers/net/wireless/iwlwifi/mvm/sta.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/iwlwifi/mvm/sta.c 
> b/drivers/net/wireless/iwlwifi/mvm/sta.c
> index d86fe432e51f..c0fc4fc0161b 100644
> --- a/drivers/net/wireless/iwlwifi/mvm/sta.c
> +++ b/drivers/net/wireless/iwlwifi/mvm/sta.c
> @@ -1196,6 +1196,7 @@ static int iwl_mvm_send_sta_key(struct iwl_mvm *mvm,
>               break;
>       case WLAN_CIPHER_SUITE_WEP104:
>               key_flags |= cpu_to_le16(STA_KEY_FLG_WEP_13BYTES);
> +             /* fall through */
>       case WLAN_CIPHER_SUITE_WEP40:
>               key_flags |= cpu_to_le16(STA_KEY_FLG_WEP);
>               memcpy(cmd.key + 3, keyconf->key, keyconf->keylen);

Applied - thanks.
N�����r��y����b�X��ǧv�^�)޺{.n�+����{��*ޕ�,�{ay�ʇڙ�,j��f���h���z��w���
���j:+v���w�j�m��������zZ+�����ݢj"��!�i

Reply via email to