On 12-06-15 16:00, Luca Coelho wrote: > From: Luciano Coelho <[email protected]> > > Hi Arend, > > Here's a small patchset that adds support for scheduled scans in > py80211.
Thanks! One general remark. It seems you are using soft-tabs where I stick to true tabs. Python is pretty anal about that so better stick to true tabs. > I'm not sure this is the right approach, I added separate classes for > each command, so feel free to ask me to change it completely if you > want and I may or may not do it. :P Me neither, but it may be a bit too classy ;-) So I would prefer to have a scheduled scan class with start and stop operation. Good to see you are using '_' consistently for class private members and functions. I need to clean it up in other files. I recently added Pyro support allowing remote access to py80211 objects and it only exposes public members and functions. Thanks again, Arend > Cheers, > Luca. > > Luciano Coelho (4): > py80211: scan: spin base scan classes off scan_request > py80211: scan: add sched_scan start class > py80211: add sched_scan stop class > py80211: scan: add matchsets support for scheduled scans > > lib/scan.py | 157 > +++++++++++++++++++++++++++++++++++++++++++++--------------- > 1 file changed, 119 insertions(+), 38 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
