Hi Arend, On Sat, 2015-06-13 at 08:26 +0200, Arend van Spriel wrote: > On 12-06-15 16:00, Luca Coelho wrote: > > Here's a small patchset that adds support for scheduled scans in > > py80211. > > Thanks! One general remark. It seems you are using soft-tabs where I > stick to true tabs. Python is pretty anal about that so better stick to > true tabs.
Uh, sorry about this. I just used what emacs does by default in python-mode and didn't give this much thought. I'll make sure my future patches conform to pythonist tab analities. :) > > I'm not sure this is the right approach, I added separate classes for > > each command, so feel free to ask me to change it completely if you > > want and I may or may not do it. :P > > Me neither, but it may be a bit too classy ;-) So I would prefer to have > a scheduled scan class with start and stop operation. Yeah, I thought so too... In any case, I saw that you applied the classy version. Shall I rework this and send new patches or shall we leave it as it is? > Good to see you are using '_' consistently for class private members and > functions. I need to clean it up in other files. I recently added Pyro > support allowing remote access to py80211 objects and it only exposes > public members and functions. Yeah, I like the idea of being strict about private versus public visibility. There was a small mistake in one of the changes you made. I'm going to send a fix for it in a second. Thanks for your help! -- Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
