On 3 May 2016 at 18:58, Krishna Chaitanya <[email protected]> wrote: > On Tue, May 3, 2016 at 9:31 PM, Johannes Berg <[email protected]> > wrote: >> On Tue, 2016-05-03 at 20:02 +0530, Krishna Chaitanya wrote: >> >>> > i don't see any issues in the powersave w.r.t driver. Isn't it a >>> > valid case? you meant implementing dynamic_ps? >> >> No, I really did mean implementing the entire PS logic in the driver, >> instead of having mac80211 do it. >> >>> If it advertise HW_SUPPORTS_DYNAMIC_PS it works fine. >>> so may be we should queue those frames and send it to >>> HW once it is out of powersave? >> >> We could, but I *really* don't want to patch over the messy and broken >> powersave code in mac80211 now. >> >> I really do think that the only way out of this mess is to implement >> powersave entirely outside of mac80211; perhaps mac80211 could provide >> helpers for it, but tying it into the MLME implementation and having >> all the PS-Poll stuff be global etc. is simply wrong today. > Okay, i understand. This again points to our discussion about mac80211 > ps a while ago. May be we should document this somewhere so that > device driver developers are aware of this? >
Why not remove PS code from the mac80211 then, while is broken and should not be used? BR Janusz > > > -- > Thanks, > Regards, > Chaitanya T K. > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
