Larry Finger <larry.fin...@lwfinger.net> writes:
> In commit d86e64768859 ("rtlwifi: rtl818x: constify local structures"),
> the configuration struct for most of the drivers was changed to be
> constant. The problem is that five of the modified drivers need to be
> able to update the firmware name based on the exact model of the card.
> As the file names were stored in one of the members of that struct,
> these drivers would fail with a kernel BUG splat when they tried to
> update the firmware name.
> Rather than reverting the previous commit, I used a suggestion by
> Johannes Berg and made the firmware file name pointers be local to
> the routines that update the software variables.
> The configuration struct of rtl8192cu, which was not touched in the
> previous patch, is now constantfied.
> Fixes: d86e64768859 ("rtlwifi: rtl818x: constify local structures")
> Suggested-by: Johannes Berg <johan...@sipsolutions.net>
> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net>
> Cc: Stable [4.8+] <sta...@vger.kernel.org>
This should be:
Cc: Stable <sta...@vger.kernel.org> # 4.8
And the plus sign isn't needed as I'll push this to 4.9.
> Cc: Julia Lawall <julia.law...@lip6.fr>
> My apologies for letting these bugs to get by my review and testing.
No worries, this is business as usual :) Excellent that you noticed this
And this again shows that simple cleanup patches are not without cost,
there is a clear risk. Has anyone done any statistics how much cleanup
patches cause regressions? My guess is that in a 5% ballpark of the
cleanup patches have some sort of issues. Of course in this case the
cleanup patch revealed a design flaw in the driver, so in this case it
was very useful.
> As they affect kernel 4.8, please push this patch as soon as possible.
> To reiterate, this patch replaces the one entitled 'Revert "rtlwifi:
> rtl818x: constify local structures"'
Ok, understood. Many thanks for making this super clear for me, makes my
life a lot easier. I'm hoping that this will make it to 4.9-rc2.
CCing Thorsten to get this regression to his radar.