On 10/12/2016 02:53 AM, Kalle Valo wrote:
Larry Finger <larry.fin...@lwfinger.net> writes:

In commit d86e64768859 ("rtlwifi: rtl818x: constify local structures"),
the configuration struct for most of the drivers was changed to be
constant. The problem is that five of the modified drivers need to be
able to update the firmware name based on the exact model of the card.
As the file names were stored in one of the members of that struct,
these drivers would fail with a kernel BUG splat when they tried to
update the firmware name.

Rather than reverting the previous commit, I used a suggestion by
Johannes Berg and made the firmware file name pointers be local to
the routines that update the software variables.

The configuration struct of rtl8192cu, which was not touched in the
previous patch, is now constantfied.

Fixes: d86e64768859 ("rtlwifi: rtl818x: constify local structures")
Suggested-by: Johannes Berg <johan...@sipsolutions.net>
Signed-off-by: Larry Finger <larry.fin...@lwfinger.net>
Cc: Stable [4.8+] <sta...@vger.kernel.org>

This should be:

Cc: Stable <sta...@vger.kernel.org> # 4.8

I know that info should be at the end of the Cc for Stable; however, versions of git since 2.6 are incorrectly mangling the line and producing the following:

Stable <sta...@vger.kernel.org#4.8+>

Of course, the smtp server refuses to send that mail, thus I got creative with my formatting.

Thanks for Thorsten's address. I will try to keep him notified of any future regressions that I find. Thus far, I have only communicated with him indirectly through LKML.

Larry

Reply via email to