On Thu, Mar 30, 2017 at 2:19 AM, Xinming Hu <huxinming...@gmail.com> wrote: > From: Xinming Hu <h...@marvell.com> > > Sanity check of interrupt number in interrupt handler is unnecessary and > confusion, remove it.
I'd reworded the explanation a bit: "If wakeup interrupt handler is called, we know that the wakeup interrupt number is valid, there is no need to check it." Otherwise: Reviewed-by: Dmitry Torokhov <d...@chromium.org> > > Signed-off-by: Xinming Hu <h...@marvell.com> > Signed-off-by: Amitkumar Karwar <akar...@marvell.com> > --- > drivers/net/wireless/marvell/mwifiex/main.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/wireless/marvell/mwifiex/main.c > b/drivers/net/wireless/marvell/mwifiex/main.c > index 30f4994..5e82602 100644 > --- a/drivers/net/wireless/marvell/mwifiex/main.c > +++ b/drivers/net/wireless/marvell/mwifiex/main.c > @@ -1503,11 +1503,9 @@ static irqreturn_t mwifiex_irq_wakeup_handler(int irq, > void *priv) > { > struct mwifiex_adapter *adapter = priv; > > - if (adapter->irq_wakeup >= 0) { > - dev_dbg(adapter->dev, "%s: wake by wifi", __func__); > - adapter->wake_by_wifi = true; > - disable_irq_nosync(irq); > - } > + dev_dbg(adapter->dev, "%s: wake by wifi", __func__); > + adapter->wake_by_wifi = true; > + disable_irq_nosync(irq); > > /* Notify PM core we are wakeup source */ > pm_wakeup_event(adapter->dev, 0); > -- > 1.8.1.4 >