Hi Brain, > -----Original Message----- > From: Brian Norris [mailto:briannor...@chromium.org] > Sent: 2017年4月4日 2:49 > To: Dmitry Torokhov > Cc: Xinming Hu; Linux Wireless; Kalle Valo; Rajat Jain; Amitkumar Karwar; > Cathy > Luo; Xinming Hu > Subject: [EXT] Re: [PATCH 3/3] mwifiex: pcie: avoid hardcode wifi-only > firmware name > > External Email > > ---------------------------------------------------------------------- > On Fri, Mar 31, 2017 at 03:50:27PM -0700, Dmitry Torokhov wrote: > > That said, I consider the whole wifi-only firmware business is quite > > fragile. Can we have unified firmware and have driver figure out what > > part shoudl be [re]loaded? > > +1. I think we should really give a stab at this first, and *then* see > how we want to patch up the flagging of support on a per-chipset basis. > As-is, you're wasting filesystem space on a duplicate firmware blob, that we > have to make sure gets updated in sync with the combined firmware every > time there's an update. > > Proof of the duplicate blob -- the latter portion of the combined FW is > identical > to the WLAN-only: > > $ cmp mrvl/pcie{usb8997_combo,8997_wlan}_v4.bin $((0x2919c)); echo $? > 0
Thanks for the review, we have a new solution for extracting wifi-only part from combo firmware, will send it in v2. Thanks Simon > > Brian
