On Tue, 2017-03-07 at 12:25 +0200, Andy Shevchenko wrote: > We return -ENODEV if ACPI provides a GPIO resource. Looks really > wrong. > If it has even been tested?
Samuel, Christophe, anything I have to address? > > Signed-off-by: Andy Shevchenko <[email protected]> > --- > drivers/nfc/st21nfca/i2c.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/nfc/st21nfca/i2c.c b/drivers/nfc/st21nfca/i2c.c > index 5a82f553906c..737384d287aa 100644 > --- a/drivers/nfc/st21nfca/i2c.c > +++ b/drivers/nfc/st21nfca/i2c.c > @@ -514,9 +514,9 @@ static int > st21nfca_hci_i2c_acpi_request_resources(struct i2c_client *client) > /* Get EN GPIO from ACPI */ > gpiod_ena = devm_gpiod_get_index(dev, ST21NFCA_GPIO_NAME_EN, > 1, > GPIOD_OUT_LOW); > - if (!IS_ERR(gpiod_ena)) { > + if (IS_ERR(gpiod_ena)) { > nfc_err(dev, "Unable to get ENABLE GPIO\n"); > - return -ENODEV; > + return PTR_ERR(gpiod_ena); > } > > phy->gpio_ena = desc_to_gpio(gpiod_ena); -- Andy Shevchenko <[email protected]> Intel Finland Oy
