Larry Finger <[email protected]> writes:

> From: Ping-Ke Shih <[email protected]>
>
> Use debugfs to dump register and btcoex status. The kbuild test robot
> <[email protected]> suggested a change to use simple_open() instead of
> a local routine.
>
> Signed-off-by: Ping-Ke Shih <[email protected]>
> Signed-off-by: Larry Finger <[email protected]>
> Cc: Yan-Hsuan Chuang <[email protected]>
> Cc: Birming Chiu <[email protected]>
> Cc: Shaofu <[email protected]>
> Cc: Steven Ting <[email protected]>

[...]

> +     if (count < 3) {
> +             /*printk("argument size is less than 3\n");*/
> +             return -EFAULT;
> +     }

> +     if (num !=  3) {
> +             /*printk("invalid write_reg parameter!\n");*/
> +             return count;
> +     }

> +     default:
> +             /*printk("error write length=%d", len);*/
> +             break;
> +     }

Dead code.

> +     /* add for debug */
> +     rtl_debug_add_one(hw);

> +     /* remove form debug */
> +     rtl_debug_remove_one(hw);

The comments are useless, the function name already tells the same.

-- 
Kalle Valo

Reply via email to