On Mon, 2018-01-15 at 13:15 -0600, Larry Finger wrote: > On 01/11/2018 01:09 AM, [email protected] wrote: > > > > From: Ping-Ke Shih <[email protected]> > > > > This commit implement the common function to sort old features, and > > add > > more new features that are get_supported_feature, > > get_supported_version, > > get_ant_det_val, ble_scan_type, ble_scan_para, bt_dev_info, > > forbidden_slot_val, afh_map and etc. > > > > Signed-off-by: Ping-Ke Shih <[email protected]> > > --- > > .../realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 309 > > ++++++++++++++++++--- > > .../realtek/rtlwifi/btcoexist/halbtcoutsrc.h | 70 +++++ > > .../wireless/realtek/rtlwifi/btcoexist/rtl_btc.c | 48 +++- > > 3 files changed, 394 insertions(+), 33 deletions(-) > > > > diff --git > > a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c > > b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c > > index 2be81fec789a..30d940cf3abf 100644 > > --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c > > +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c > > @@ -207,6 +207,102 @@ u8 rtl_get_hwpg_package_type(struct rtl_priv > > *rtlpriv) > > return rtlhal->package_type; > > } > > > > +static > > +bool halbtc_is_hw_mailbox_exist(struct btc_coexist *btcoexist) > > +{ > > + if (IS_HARDWARE_TYPE_8812(btcoexist->adapter)) > > + return false; > > + else > > + return true; > Once you have returned false for 8812, you do not need the 'else'. > Use a simple > ' return true;'. As this is the only objection in this patch, > I will let it > pass. Some user with a suitable tool will change it. > > > > > +} > > + > > +static > > +bool halbtc_send_bt_mp_operation(struct btc_coexist *btcoexist, u8 > > op_code, > > + u8 *cmd, u32 len, unsigned long > > wait_ms) > --snip-- > > > > > > > diff --git > > a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h > > b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h > > index 5a7816ff6877..cbbf5e5a9c9b 100644 > > --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h > > +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h > > @@ -278,6 +278,8 @@ enum btc_get_type { > > BTC_GET_U4_VENDOR, > > BTC_GET_U4_SUPPORTED_VERSION, > > BTC_GET_U4_SUPPORTED_FEATURE, > > + BTC_GET_U4_BT_DEVICE_INFO, > > + BTC_GET_U4_BT_FORBIDDEN_SLOT_VAL, > > BTC_GET_U4_WIFI_IQK_TOTAL, > > BTC_GET_U4_WIFI_IQK_OK, > > BTC_GET_U4_WIFI_IQK_FAIL, > > @@ -459,6 +461,19 @@ typedef bool (*bfp_btc_get)(void > > *btcoexist, u8 get_type, void *out_buf); > > > > typedef bool (*bfp_btc_set)(void *btcoexist, u8 set_type, > > void *in_buf); > > > > +typedef u32 (*bfp_btc_get_bt_coex_supported_feature)(void > > *btcoexist); > > + > > +typedef u32 (*bfp_btc_get_bt_coex_supported_version)(void > > *btcoexist); > > + > > +typedef u8 (*bfp_btc_get_ant_det_val_from_bt)(void *btcoexist); > > + > > +typedef u8 (*bfp_btc_get_ble_scan_type_from_bt)(void *btcoexist); > > + > > +typedef u32 (*bfp_btc_get_ble_scan_para_from_bt)(void *btcoexist, > > u8 scan_type); > > + > > +typedef bool (*bfp_btc_get_bt_afh_map_from_bt)(void *btcoexist, u8 > > map_type, > > + u8 *afh_map); > > + > > typedef void (*bfp_btc_set_bt_reg)(void *btc_context, u8 > > reg_type, u32 offset, > > u32 value); > I would prefer that you not add additional typedef statements, but I > will let it > pass. > Thank you for pointing out. I'll remove all typedef in next patchset.
> > Acked-by: Larry Finger <[email protected]> > > ------Please consider the environment before printing this e-mail.
