On 3/11/2018 5:05 PM, Andres Rodriguez wrote:
Your patch series then should also have the driver callers who you
want to modify to use this new API. Collect from the 802.11 folks the
other drivers which I think they wanted changed as well.


Arend, Kalle, would love to hear your feedback.

I am not sure if it was ath10k, but Kalle will surely know. The other driver firing a whole batch of firmware requests is iwlwifi. These basically try to get latest firmware version and if not there try an older one.

The brcmfmac driver I maintain is slightly different. It downloads two distinct pieces of firmware of which one is optional for certain configurations. Currently, my driver does two asynchronous requests for it, but I consider changing it and only make the first request asynchronous and the second request synchronous. You can look at the current code in drivers/net/wireless/broadcom/brcmfmac/firmware.c. However, I did quite some restructuring last week. Anyway, I probably will end up using the "optional" api where appropriate.

Regards,
Arend

Reply via email to