Kalle Valo <kv...@codeaurora.org> writes:

> From: Sebastian Gottschall <s.gottsch...@newmedia-net.de>
>
> Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 based
> chipsets with on chipset connected led's using WMI Firmware API.  The LED
> device will get available named as "ath10k-phyX" at sysfs and can be 
> controlled
> with various triggers.  adds also debugfs interface for gpio control.
>
> Signed-off-by: Sebastian Gottschall <s.gottsch...@dd-wrt.com>

>From and Signed-off-by fields do not match. Sebastian, which domain
should it be?

> Reviewed-by: Steve deRosier <deros...@cal-sierra.com>
> [kvalo: major reorg and cleanup]
> Signed-off-by: Kalle Valo <kv...@codeaurora.org>
> ---
>
> v13:
>
> * only compile tested!

So testing is very welcome.

> --- a/drivers/net/wireless/ath/ath10k/Kconfig
> +++ b/drivers/net/wireless/ath/ath10k/Kconfig
> @@ -52,6 +52,16 @@ config ATH10K_DEBUGFS
>  
>         If unsure, say Y to make it easier to debug problems.
>  
> +config ATH10K_LEDS
> +     bool "Atheros ath10k LED support"
> +     depends on ATH10K
> +     select MAC80211_LEDS
> +     select LEDS_CLASS
> +     select NEW_LEDS
> +     default y
> +     help
> +       This option is necessary, if you want LED support for chipset 
> connected led pins. If unsure, say N.
> +

I started to wonder is this Kconfig option even needed, feels pretty
pointless. Why not just make config ATH10K depend on LED stuff, just
like ath9k already does?

> --- a/drivers/net/wireless/ath/ath10k/core.h
> +++ b/drivers/net/wireless/ath/ath10k/core.h
> @@ -25,6 +25,7 @@
>  #include <linux/pci.h>
>  #include <linux/uuid.h>
>  #include <linux/time.h>
> +#include <linux/leds.h>
>  
>  #include "htt.h"
>  #include "htc.h"
> @@ -883,7 +884,6 @@ struct ath10k {
>       u32 low_5ghz_chan;
>       u32 high_5ghz_chan;
>       bool ani_enabled;
> -
>       bool p2p;
>  
>       struct {

Unrelated change, I'll fix that in v14.

-- 
Kalle Valo

Reply via email to