Tony Chuang <[email protected]> writes: >> > + pkt_info->bmc = bmc; >> > + pkt_info->sec_type = sec_type; >> > + pkt_info->tx_pkt_size = skb->len; >> > + pkt_info->offset = chip->tx_pkt_desc_sz; >> > + pkt_info->qsel = skb->priority; >> >> Shouldn't be qsel somehow mapped from skb->priority ? > > Firmware handles it.
What if meaning of skb->priority changes in the future? I don't think it's safe to provide kernel internal values to firmware, you should do some kind of mapping in the driver. -- Kalle Valo
