Hi,
On 10/8/2018 8:01 PM, Johannes Berg wrote:
>> + *currbyte = (u32)0 & DRV_HANDLER_MASK;
> You do this a few times, not sure what it's supposed to achieve?
>
Agree, the bitwise operation is useless here and this logic should be
modified.
>
> So far I guess I'd say:
> * use more kernel infra, in particular {get,put}_unaligned_le{16,32}
> * name your device/driver-specific constants better, rather than things
> like "SET_CFG" which leave everyone wondering if it's specific to
> this driver or something from elsewhere
>
Thanks for your inputs.
I will use your suggestion while submitting the refactor code.
Regards,
Ajay
