(fixing top posting, PLEASE do not top post) Rakesh Pillai <[email protected]> writes:
> On 2018-12-14 17:26, Kalle Valo wrote: >> Kalle Valo <[email protected]> writes: >> >>> From: Rakesh Pillai <[email protected]> >>> >>> HL2.0 firmware does not support setting quiet mode. If the host >>> driver sends >>> the quiet mode setting command to the HL2.0 firmware, it crashes >>> with the below >>> signature. >>> >>> fatal error received: err_qdi.c:456:EX:wlan_process:1:WLAN >>> RT:207a:PC=b001b4f0 >>> >>> The quiet mode command support is exposed by the firmware via >>> thermal throttle >>> wmi service. Enable ath10k thermal support if thermal throttle wmi >>> service bit >>> is set. 10.x firmware versions support this feature by default, but >>> unfortunately do not advertise the support via service flags, hence >>> have to >>> manually set the service flag in ath10k_core_compat_services(). >>> >>> Compile tested only. >> >> I'm planning to queue this for 4.20 as wcn3990 support won't work >> otherwise. But I wasn't able to test this so can someone help, >> please? > > I tested this patch on WCN3990 and did basic STA mode sanity. I do not > see any crash with this fix. Thanks. I now tested this with firmware 10.2.4.70.9-2 on QC988X. I'll update the commit log accordingly. -- Kalle Valo
