On Fri, 2019-06-14 at 12:11 +0200, Lorenzo Bianconi wrote: > Looking at __ieee80211_amsdu_copy() now I got why other drivers copy hdrlen + > 8, thx :) > In our case reuse_frag is true in __ieee80211_amsdu_copy, so we will end up > copying 32B + ether_len. Anyway I think 32 is a little bit too low and we > could get > better performances increasing it a little bit. > A typical use case (e.g IPv6 + TCP): > > IPv6 = 40B, TCP = 32B --> so 72B..I guess 128B is a good value :) > @Felix, Johannes: what do you think?
I think while we might *allocate* more, I don't think we should *copy* more, since then the TCP payload will no longer be in pages. It'd probably be better to implement leaving enough tailroom (allocate 128), but copying nothing, unless the *entire* packet fits. johannes
