Hi Johannes,

On 10/8/19 3:16 PM, Johannes Berg wrote:
On Tue, 2019-10-08 at 13:50 -0500, Denis Kenzior wrote:
Hi Johannes,

But they shouldn't change due a mac address change?  I wonder if we can
further relax the requirements to allow mac change if
NL80211_SCAN_FLAG_RANDOM_ADDR was used?

No, at least with HW scan that would completely confuse the driver -
since from the driver's POV we'd remove the interface it's currently
managing the scan for.

So help me understand this better.

include/net/mac80211.h:

        int (*hw_scan)(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
                       struct ieee80211_scan_request *req);

How is it difficult to understand that with an API like that, it might
not be a good idea to remove the vif from the driver while it's
scanning?

Right, so you're talking in the context of this implementation which performs a remove/add interface. You're right about that.

But I was asking more in general terms. If all we're doing is scanning, can we just change the mac? Anyway, not important. Maybe I bring this up once this set is accepted.

Regards,
-Denis

Reply via email to