Hi Amit,
On 2020/2/3 下午1:51, Amit Kumar Mahapatra wrote:
Hi,
The patch looks fine to me.
But I have few queries, @Michal Simek <mailto:[email protected]>
kindly share your thoughts.
I had sent spi-nor framework and zynq/zynqmp qspi driver rebse_v5.4
patches to https://gitenterprise.xilinx.com/Linux/linux-xlnx and
@qwang2 <mailto:[email protected]> has sent spi-nor
framework and zynq/zynqmp qspi driver rebse_v5.4 patches to
http://git.yoctoproject.org/cgit.cgi/linux-yocto-dev/tree/?h=standard/xlnx-soc
Implementation wise there is a diff between both these trees w.r.t
spi-nor framework and zynq/zynqmp qspi driver files.
Are these trees independent of each other, hence we can have diff
between both these trees ?
Yes, they are independent. The rebase_v5.4 patches in
https://gitenterprise.xilinx.com/Linux/linux-xlnx will be applied to the
later linux-yocto kernel versions (v5.5, v5.6, etc).
Thanks,
Quanyang
Regards,
Amit
*From:* qwang2 <[email protected]>
*Sent:* Monday, February 3, 2020 7:22 AM
*To:* Bruce <[email protected]>; Michal Simek
<[email protected]>; Amit Kumar Mahapatra <[email protected]>; Naga
Sureshkumar Relli <[email protected]>
*Cc:* [email protected]
*Subject:* Re: [V2] [linux-yocto][PATCH 1/1] mtd: spi-nor: fix
erasesize for dual qspi mode
Ping.
On 2020/1/6 下午9:33, quanyang.wang wrote:
From: Quanyang Wang<[email protected]>
<mailto:[email protected]>
The zcu102 and zc706 boards support qspi dual mode, and in
the dual mode, the erasesize for mtd device should be twice
as much as the erasesize for each nor flash chip.
Signed-off-by: Quanyang Wang<[email protected]>
<mailto:[email protected]>
---
V1 ---> V2:
1) use nor->shift instead of 2.
2) put the implementation in the function spi_nor_select_erase().
drivers/mtd/spi-nor/spi-nor.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index c6fca2a81c44..5949ff63df46 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -4793,7 +4793,7 @@ static int spi_nor_select_erase(struct spi_nor *nor)
if (!erase)
return -EINVAL;
nor->erase_opcode = erase->opcode;
- mtd->erasesize = erase->size;
+ mtd->erasesize = erase->size << nor->shift;
return 0;
}
@@ -4811,7 +4811,7 @@ static int spi_nor_select_erase(struct spi_nor *nor)
if (!erase)
return -EINVAL;
- mtd->erasesize = erase->size;
+ mtd->erasesize = erase->size << nor->shift;
return 0;
}
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#8362):
https://lists.yoctoproject.org/g/linux-yocto/message/8362
Mute This Topic: https://lists.yoctoproject.org/mt/69464832/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
