Hi Amit,

On 12/3/20 6:36 PM, Amit Kumar Mahapatra wrote:
Hello Quanyang,

Thank you for the patches.

With 0003-spi-spi-zynqmp-gqspi-use-wait_for_completion_timeout.patch I am 
seeing mtd_debug erase, write and read failures.

root@xilinx-zc1751-dc1-2020_2:~# cat /proc/mtd
dev:    size   erasesize  name
mtd0: 01e00000 00010000 "boot"
mtd1: 00040000 00010000 "bootenv"
mtd2: 021c0000 00010000 "kernel"
root@xilinx-zc1751-dc1-2020_2:~# dd if=/dev/urandom of=test.bin bs=31457280 
count=1
1+0 records in
1+0 records out
root@xilinx-zc1751-dc1-2020_2:~# mtd_debug erase /dev/mtd0 0x00 x01e00000
Erased 0 bytes from address 0x00000000 in flash
root@xilinx-zc1751-dc1-2020_2:~# mtd_debug write /dev/mtd0 0x00 x01e00000 
test.bin
file_to_flash: fread, size 0, n 0
fread(): Success
root@xilinx-zc1751-dc1-2020_2:~# mtd_debug read /dev/mtd0 0x00 x01e00000 
test1.bin
Copied 0 bytes from address 0x00000000 in flash to test1.bin

Thank you for your review.

It seems that the "x01e00000" should be "0x1e00000" in the commands.

Would you please do me a favor to run the commands as below at your side?

mtd_debug erase /dev/mtd0 0x00 0x01e00000

mtd_debug write /dev/mtd0 0x00 0x01e00000 test.bin

mtd_debug read /dev/mtd0 0x00 0x01e00000 test1.bin


At my side, I didn't reproduce the error above but triggered a calltrace as below, and I need to do

a check at my patches about this calltrace.

Thanks,

Quanyang


root@xilinx-zynqmp:~# cat /proc/mtd
dev:    size   erasesize  name
mtd0: 00100000 00001000 "qspi-fsbl-uboot"
mtd1: 00500000 00001000 "qspi-linux"
mtd2: 00020000 00001000 "qspi-device-tree"
mtd3: 011c0000 00001000 "qspi-rootfs"

root@xilinx-zynqmp:~# mtd_debug erase /dev/mtd3 0x00 x011c0000
Erased 0 bytes from address 0x00000000 in flash

root@xilinx-zynqmp:~# mtd_debug erase /dev/mtd3 0x00 0x011c0000
Erased 18612224 bytes from address 0x00000000 in flash

root@xilinx-zynqmp:~# mtd_debug write /dev/mtd3 0x00 0x011c0000 test.bin
Copied 18612224 bytes from test.bin to address 0x00000000 in flash

root@xilinx-zynqmp:~# mtd_debug read /dev/mtd3 0x00 0x011c0000 test1.bin
[   52.700029] zynqmp-qspi ff0f0000.spi: swiotlb buffer is full (sz: 4194304 bytes), total 32768 (slots), used 0 (slots)
[   52.710653] zynqmp-qspi ff0f0000.spi: ERR:rxdma:memory not mapped
[   52.851121] Unable to handle kernel paging request at virtual address 00000000003fffc0
[   52.859046] Mem abort info:
[   52.861838]   ESR = 0x96000144
[   52.864898]   EC = 0x25: DABT (current EL), IL = 32 bits
[   52.870208]   SET = 0, FnV = 0
[   52.873263]   EA = 0, S1PTW = 0
[   52.876403] Data abort info:
[   52.879287]   ISV = 0, ISS = 0x00000144
[   52.883116]   CM = 1, WnR = 1
[   52.886070] user pgtable: 4k pages, 48-bit VAs, pgdp=0000000804da6000
[   52.892501] [00000000003fffc0] pgd=0000000000000000, p4d=0000000000000000
[   52.899282] Internal error: Oops: 96000144 [#1] PREEMPT SMP
[   52.904844] Modules linked in:
[   52.907920] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.10.0-rc5-00042-ge63dbb63d8bf-dirty #185
[   52.916615] Hardware name: ZynqMP ZCU102 Rev1.0 (DT)
[   52.921590] pstate: 00000085 (nzcv daIf -PAN -UAO -TCO BTYPE=--)
[   52.927614] pc : __dma_inv_area+0x28/0x58
[   52.931634] lr : arch_sync_dma_for_cpu+0x20/0x30
[   52.936251] sp : ffff80001205bdc0
[   52.939568] x29: ffff80001205bdc0 x28: ffff800011cd3240
[   52.944897] x27: 0000000000000001 x26: ffff80001142a228
[   52.950227] x25: ffff800011f6039f x24: 0000000000400000
[   52.955558] x23: 0000000000000002 x22: ffff00080035ec10
[   52.960888] x21: ffffffffffffffff x20: 0000000000000000
[   52.966218] x19: ffffffffffffffff x18: 0000000000000000
[   52.971547] x17: 0000000000000000 x16: 0000000000000000
[   52.976877] x15: 0000000000000000 x14: 0000000000000000
[   52.982208] x13: 003d090000000000 x12: 00003d08ffab34f8
[   52.987538] x11: 0000000000000040 x10: ffff800011d526a0
[   52.992868] x9 : 0000000000000002 x8 : 0000000000000000
[   52.998198] x7 : 0000000000000000 x6 : 0000000000000000
[   53.003528] x5 : ffff000800400248 x4 : 0000000000000000
[   53.008858] x3 : 000000000000003f x2 : 0000000000000040
[   53.014188] x1 : 00000000003fffc0 x0 : ffffffffffffffff
[   53.019517] Call trace:
[   53.021980]  __dma_inv_area+0x28/0x58
[   53.025655]  dma_unmap_page_attrs+0x144/0x208
[   53.030022]  zynqmp_qspi_irq+0x1b4/0x2a8
[   53.033955]  __handle_irq_event_percpu+0x54/0x170
[   53.038666]  handle_irq_event_percpu+0x34/0x90
[   53.043118]  handle_irq_event+0x48/0xe0
[   53.046968]  handle_fasteoi_irq+0xa4/0x130
[   53.051075]  generic_handle_irq+0x30/0x48
[   53.055090]  __handle_domain_irq+0x64/0xc0
[   53.059197]  gic_handle_irq+0xa8/0xe0
[   53.062868]  el1_irq+0xbc/0x180
[   53.066026]  cpuidle_enter_state+0x134/0x2f0
[   53.070311]  cpuidle_enter+0x38/0x50
[   53.073894]  call_cpuidle+0x1c/0x40
[   53.077391]  do_idle+0x200/0x268
[   53.080629]  cpu_startup_entry+0x28/0x68
[   53.084566]  rest_init+0xd8/0xe8
[   53.087802]  arch_call_rest_init+0x10/0x1c
[   53.091905]  start_kernel+0x4b4/0x4ec
[   53.095589] Code: d1000443 ea03003f 8a230021 54000040 (d50b7e21)
[   53.101691] ---[ end trace f1f0dc492a03b9d5 ]---
[   53.106314] Kernel panic - not syncing: Oops: Fatal exception in interrupt
[   53.113193] SMP: stopping secondary CPUs
[   53.117209] Kernel Offset: disabled
[   53.120705] CPU features: 0x0240002,20002004
[   53.124971] Memory Limit: none
[   53.128051] ---[ end Kernel panic - not syncing: Oops: Fatal exception in interrupt ]---



Regards,
Amit


-----Original Message-----
From: Michal Simek <[email protected]>
Sent: Thursday, November 26, 2020 5:31 PM
To: [email protected]; Bruce <[email protected]>;
Michal Simek <[email protected]>
Cc: [email protected]; Amit Kumar Mahapatra
<[email protected]>
Subject: Re: [linux-yocto] [linux-yocto-dev standard/xlnx-soc] xlnx-soc:
porting SDK patches to kernel v5.10

Hi,


On 26. 11. 20 11:19, [email protected] wrote:
From: Quanyang Wang <[email protected]>

Hi Bruce,

Would you please help remove the obsolete branch standard/xlnx-soc in
linux-yocto-dev and apply these patches for v5.10 as below to the new
branch standard/xlnx-soc?
There are 1451 patches in this pull request.

Among them, 1443 patches are picked from
https://github.com/Xilinx/linux-xlnx.git xlnx_rebase_v5.4 (tag
xlnx_rebase_v5.4_2020.2).
and some of them are modified to adapt to the v5.10. And there are 4 new
patches.
Hi Michal,
Would you please help review these 4 patches as below?
The new 4 patches are made to fix issues in mainline zynqmp gqspi
driver in v5.10 since the driver has changed the framework from spi master
to spi mem.
0001-spi-spi-zynqmp-gqspi-transmit-dummy-circles-by-using.patch
0002-spi-spi-zynqmp-gqspi-add-mutex-locking-for-exec_op.patch
0003-spi-spi-zynqmp-gqspi-use-wait_for_completion_timeout.patch
0004-spi-spi-zynqmp-gqspi-fix-zynqmp_qspi_read_op-assign-.patch

Amit: Can you please take a look at them?

Thanks,
Michal
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#9217): 
https://lists.yoctoproject.org/g/linux-yocto/message/9217
Mute This Topic: https://lists.yoctoproject.org/mt/78526815/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to