On 13-01-18 01:53 PM, Kamble, Nitin A wrote:


-----Original Message-----
From: Hart, Darren
Sent: Friday, January 18, 2013 10:52 AM
To: Kamble, Nitin A
Cc: bruce.ashfi...@windriver.com; Zanussi, Tom; linux-
yo...@yoctoproject.org
Subject: Re: [meta branch v3 11/12] meta: add config fragment for gma500
graphics driver

On 01/16/2013 11:24 AM, nitin.a.kam...@intel.com wrote:
From: Nitin A Kamble <nitin.a.kam...@intel.com>

This provides a way to choose GMA500 DRM graphics driver.

Signed-off-by: Nitin A Kamble <nitin.a.kam...@intel.com>
---
  .../features/drm-gma500/drm-gma500.cfg             |    3 +++
  .../features/drm-gma500/drm-gma500.scc             |    1 +
  2 files changed, 4 insertions(+), 0 deletions(-)  create mode 100644
meta/cfg/kernel-cache/features/drm-gma500/drm-gma500.cfg
  create mode 100644
meta/cfg/kernel-cache/features/drm-gma500/drm-gma500.scc

diff --git a/meta/cfg/kernel-cache/features/drm-gma500/drm-gma500.cfg
b/meta/cfg/kernel-cache/features/drm-gma500/drm-gma500.cfg
new file mode 100644
index 0000000..b5024c0
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/drm-gma500/drm-gma500.cfg
@@ -0,0 +1,3 @@
+CONFIG_DRM=y
+CONFIG_DRM_GMA500=m
+CONFIG_DRM_KMS_HELPER=m

Is there are reason you are choosing modules here? In my opinion, as we are
building BSP-specific kernels, there is really no need for modules.
Someone else was arguing for converting =y to =m on some other bits earlier
as well. One problem with this is it makes building smaller systems without
module support even more difficult.

Is there any real advantage to building as modules?

I agree, this would be better done as built in kernel driver than kernel module.
I tried to do what other config fragments for graphics driver were doing in the 
tree.


I haven't merged this series yet, since I'm finishing up the 3.4.25/3.4.26
and preempt-rt refreshes.

I'll wait for heads up that the series is changed with this from m -> y
before pulling.

Bruce

Nitin



--
Darren

diff --git a/meta/cfg/kernel-cache/features/drm-gma500/drm-gma500.scc
b/meta/cfg/kernel-cache/features/drm-gma500/drm-gma500.scc
new file mode 100644
index 0000000..fd00573
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/drm-gma500/drm-gma500.scc
@@ -0,0 +1 @@
+kconf hardware drm-gma500.cfg


--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

_______________________________________________
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto

Reply via email to