On 11/7/2013, 8:12 PM, Paul Butler wrote:
From: David Mercado <david.merc...@windriver.com>
This patch fixes setting of IRQ type to all clusters. Previously was
only working for first cluster.
While I don't doubt that this is true, switching from i/4 to i*4
is significant.
I can't see enough from the context of the patch, what is "i", and
how do we know that there's always a cpu at i * 4 ?
Bruce
Signed-off-by: David Mercado <david.merc...@windriver.com>
---
arch/arm/mach-axxia/axxia-gic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-axxia/axxia-gic.c b/arch/arm/mach-axxia/axxia-gic.c
index 2c2dfba..c074f6c 100644
--- a/arch/arm/mach-axxia/axxia-gic.c
+++ b/arch/arm/mach-axxia/axxia-gic.c
@@ -344,7 +344,7 @@ static int gic_set_type(struct irq_data *d, unsigned int
type)
* smp_call_function_single().
*/
local_irq_enable();
- smp_call_function_single((i/4),
+ smp_call_function_single((i * 4),
gic_set_type_wrapper, &data, 1);
local_irq_disable();
if (data.status != 0)
_______________________________________________
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto
