On 10/23/2012 06:09 AM, Tony Cheneau wrote:
> It is intended that the IEEE 802.15.4 standard uses the 0xFFFF short address 
> (2
> bytes) for message broadcasting.
> 
> Signed-off-by: Tony Cheneau <tony.chen...@amnesiak.org>
> ---
>  net/ieee802154/6lowpan.c |   21 +++++++++++++--------
>  1 files changed, 13 insertions(+), 8 deletions(-)
> 
> diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
> index 49d91df..8a2ee95 100644
> --- a/net/ieee802154/6lowpan.c
> +++ b/net/ieee802154/6lowpan.c
> @@ -577,21 +577,26 @@ static int lowpan_header_create(struct sk_buff *skb,
>        * this isn't implemented in mainline yet, so currently we assign 0xff
>        */
>       {
> +             mac_cb(skb)->flags = IEEE802154_FC_TYPE_DATA;
> +
>               /* prepare wpan address data */
>               sa.addr_type = IEEE802154_ADDR_LONG;
>               sa.pan_id = 0xff;
> -
> -             da.addr_type = IEEE802154_ADDR_LONG;
> -             da.pan_id = 0xff;
> -
> -             memcpy(&(da.hwaddr), daddr, 8);
>               memcpy(&(sa.hwaddr), saddr, 8);
>  
> -             mac_cb(skb)->flags = IEEE802154_FC_TYPE_DATA;
> +             da.pan_id = 0xff;
> +             /* if the destination address is the broadcast address,
> +                use short address */

David likes comments in the networking code to look

                /* Like
                 * this
                 */

Note that the comment is closed on a line by itself. There's an example
at the top of this hunk.


------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel

Reply via email to