>> @@ -881,6 +882,12 @@ static int at86rf230_probe(struct spi_device *spi)

>>      if (rc)
>>              goto err_gpio_dir;
>>  +   if (lp->irq_type) {
> Stray space before the + in the above line. Are you using git
> format-patch and git send-email?

Argh..., missed this :/ I used git format-patch and loaded the patches
into Thunderbird using a plugin to import files. I fear I should
consider this broken and give git send-email a try.

>> +    if (lp->irq_type) {
>> +            rc = irq_set_irq_type(spi->irq, lp->irq_type);

>> +            if (rc)
>> +                    goto err_gpio_dir;
>> +    }
>> + 
> Since 0x0 is IRQ_TYPE_NONE, maybe you should print a warning here if
> lp->irq_type is 0.

I will try to fix the stray spaces and add a warning here. Will try to
resend the patches the next days.

Thanks,
Sascha

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature to help me
spread!

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel

Reply via email to