On 03/18/2013 07:07 PM, jonsm...@gmail.com wrote: > Why isn't the serial driver in mainline?
The serial driver has a couple of outstanding issues which may or may not need to be corrected before it goes into mainline (since it is ultimately not up to me): 1. It needs a new name. Maybe ieee802154-serial or something similar. I think serial.ko will raise some eyebrows. 2. As stands currently, it needs a line discipline to be added into tty.h. I know that's just the way it works, but I get the feeling that since it touches that file, it's going get more scrutiny than other patches which don't. If there were some way to avoid this, ie: if there were a way to attach a driver to a serial port without setting a globally specified integer from userspace, I think it'd be a lot easier. Maybe sysfs can help us here. Maybe not. I don't know. This is only important because of how it ties in to #3. 3. If the serial protocol is going to be something that works across devices, ie: if it's going to be "the" IEEE802154 protocol (and that's what we're saying with a discipline named N_IEEE802154), It's going to need to be better specified, and more complete. The current documentation is at [1]. 4. Bugs/features. Right now there's no way to turn the filters on from the driver (or not any that I could get to work). I also get lockups, where it will stop sending or receiving. I haven't investigated whether that's driver or firmware related. 5. As Jon mentioned, the code needs to have all the Zigbee references removed. We need to do that in the protocol too (all the zb references). 6. Much cleanup work needs to be done. Duplicated code (needs refactoring), unnecessary memcpy()ing, and style issues. Don't get me wrong. I'm not trying to be a naysayer. I think we can certainly get it in, but there's some work that will need to be done first. If someone wants to champion this effort (Jon?), I'd recommend correcting some of the obvious stuff, and then sending it as an RFC patch to net-next, and see what David Miller and Eric Dumazet have to say. Alan. [1] https://sourceforge.net/apps/trac/linux-zigbee/wiki/SerialV1 ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel