Stefan Schmidt wrote:
> I think the MSB and LSB comments can go easily.

As another step towards reaching the 80 columns goal, you could
also consider getting rid of the & 0xff maskings.

As far as I can tell, they don't help to avoid W=3 warnings (i.e.,
-Wconversion; you'd have to cast for that), and the behaviour you
explicitly ask for is already guaranteed by the C standard (K&R
2nd Ed., section A6.2).

Without the masking, the code is a bit more vulnerable to changes
in the __at86rf230_write API, but I'm not sure this is something
we need to worry about.

- Werner

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel

Reply via email to