Hello. On Mon, 2013-03-25 at 17:49, Werner Almesberger wrote: > Stefan Schmidt wrote: > > I think the MSB and LSB comments can go easily. > > As another step towards reaching the 80 columns goal, you could > also consider getting rid of the & 0xff maskings. > > As far as I can tell, they don't help to avoid W=3 warnings (i.e., > -Wconversion; you'd have to cast for that), and the behaviour you > explicitly ask for is already guaranteed by the C standard (K&R > 2nd Ed., section A6.2). > > Without the masking, the code is a bit more vulnerable to changes > in the __at86rf230_write API, but I'm not sure this is something > we need to worry about.
I only did it for playing safe not for conversion. Given the K&R guarantee I removed them now. Seems I need to pull out my K&R again and re-read it. :) Will be in re-submit of the patch. regards Stefan Schmidt ------------------------------------------------------------------------------ Own the Future-Intel® Level Up Game Demo Contest 2013 Rise to greatness in Intel's independent game demo contest. Compete for recognition, cash, and the chance to get your game on Steam. $5K grand prize plus 10 genre and skill prizes. Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
